Remove Firefox work-around to type Space in RichText components inside button/summary #53014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
[Feature] Rich Text
|
Size Change: -72 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e3ff402. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5678303043
|
|
Have you tested Safari as well? |
t-hamano
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Nice work, @Aljullu!
I am a Windows user and have tested in the following environments:
- OS: Windows 11
- Firefox 115.0.2: Works as expected
- Edge 115.0.1901.183: No regression
- Chrome 115.0.5790.110: No regression
I approve this PR, but would like to wait for someone to test it in various browsers on Mac 😅
|
Thanks for taking a look, folks!
I don't have a Mac, but tested on GNOME Web, which uses WebKit as its engine, the same as Safari, and it works great there. I tested Chrome and Firefox as well. |
|
Sorry for the late reply. Just to be sure, I will call out on Slack to see if anyone can test this PR on a Mac. |
|
I tested this PR on Mac with different browsers:
It works correctly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ce1ef42 from #50540.
What and why?
In #50540, a work-around was introduced to fix typing Space when the
RichTextcomponent is inside button/summary in Firefox. Since then, the Firefox bug has been fixed and released in the latest Firefox ESR version, Firefox 115. Because of that, it should be safe to remove the work-around from the Gutenberg codebase.Testing Instructions
Screenshots or screencast
Enregistrament.de.pantalla.des.de.2023-07-20.11-31-57.webm